Add back API-version gate for image-create events#12
Merged
vvoland merged 1 commit intovvoland:image-createfrom Jun 17, 2024
Merged
Add back API-version gate for image-create events#12vvoland merged 1 commit intovvoland:image-createfrom
vvoland merged 1 commit intovvoland:image-createfrom
Conversation
Could use a claner option, and probably we should move the test to "integration/", but this works for now, because the events API didn't change since 17.06, and we just specify a newer version of the API (which, technicaly, the 17.06 CLI doesn't support, but DOCKER_API_VERSION allows any version to be set). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Jun 15, 2024
Comment on lines
+276
to
+282
| shouldSkip := func(ev events.Message) bool { return false } | ||
| if versions.LessThan(httputils.VersionFromContext(ctx), "1.46") { | ||
| // Image create events were added in API 1.46 | ||
| shouldSkip = func(ev events.Message) bool { | ||
| return ev.Type == "image" && ev.Action == "create" | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
I changed this slightly from your original approach so that we don't have to do the version compare in each iteration, but instead set up a filter function once.
vvoland
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could use a claner option, and probably we should move the test to "integration/", but this works for now, because the events API didn't change since 17.06, and we just specify a newer version of the API (which, technicaly, the 17.06 CLI doesn't support, but DOCKER_API_VERSION allows any version to be set).